Update azure docs to include new param #27680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
vinay-gopalan
approved these changes
Jul 3, 2024
gsantos-hc
reviewed
Jul 3, 2024
| @@ -216,6 +216,8 @@ information about roles. | |||
| Accepts time suffixed strings ("1h") or an integer number of seconds. Defaults to the system/engine default TTL time. | |||
| - `max_ttl` (`string: ""`) – Specifies the maximum TTL for service principals generated using this role. Accepts time | |||
| suffixed strings ("1h") or an integer number of seconds. Defaults to the system/engine max TTL time. | |||
| - `explicit_max_ttl` (`string: ""`) – Specifies the explicit maximum lifetime of the lease and service principal. | |||
There was a problem hiding this comment.
How about:
Limits the lifetime of the service principal secret in Azure and sets an upper bound on the corresponding lease's TTL. This lifetime cannot be changed once a lease is created, and the lease cannot be renewed beyond the expiration of this lifetime. If not set or set to zero, the service principal secret will be created with a default duration of 10 years and deleted once the corresponding lease in Vault expires.
|
Sorry – Looks like my comments posted after this was merged 🤷♂️ It was a small improvement anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very small PR to update azure docs to include new param
explicit_max_ttl.PR: hashicorp/vault-plugin-secrets-azure#199